Hyprland: Make sure image window is moved to correct workspace#223
Open
thatDudo wants to merge 1 commit intojstkdng:masterfrom
Open
Hyprland: Make sure image window is moved to correct workspace#223thatDudo wants to merge 1 commit intojstkdng:masterfrom
thatDudo wants to merge 1 commit intojstkdng:masterfrom
Conversation
|
Owner
|
can you post some pics of the issue before/after? |
Contributor
Author
Owner
|
workspaces aren't treated the same way in wayland compositors so it should be wm dependent. Does this work if the terminal doesn't have a workspace assigned? |
Contributor
Author
Ok, then it is probably good to have the function being called from the hyprland.cpp file.
I think every window in hyprland always has a workspace assigned to it. The id should be unique even with things that mess with workspaces like hyprsome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






The image window was always opened in the currently focused workspace instead of the workspace belonging to the terminal window. I wasnt sure implementation wise if the change_workspace should be called in wayland.cpp (like move_window) since it can be kept hidden from it without problems.